Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update eslint:recommended section in Migrate to v9.x #17908

Merged
merged 1 commit into from Dec 27, 2023

Conversation

mdjermanovic
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

Updates the Migrate to v9.x document to include changes made in 60dea3e

What changes did you make? (Give an overview)

  • Added no-new-native-nonconstructor to the list of rules that have been enabled in eslint:recommended, and no-new-symbol to the list of rules that have been removed from eslint:recommended.
  • Also fixed typo replacment -> replacement
  • Also added a Migrate to v9x link to https://eslint.org/docs/latest/use/#migrating

Is there anything you'd like reviewers to focus on?

The migrate-to-9.x link text matches the title, but the list looks inconsistent.

@mdjermanovic mdjermanovic requested a review from a team as a code owner December 27, 2023 15:22
@eslint-github-bot eslint-github-bot bot added the documentation Relates to ESLint's documentation label Dec 27, 2023
Copy link

netlify bot commented Dec 27, 2023

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit 8a47475
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/658c41312cd6e30008fe4d99
😎 Deploy Preview https://deploy-preview-17908--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nzakas nzakas merged commit 1da0723 into main Dec 27, 2023
17 checks passed
@nzakas nzakas deleted the migration-more-recommended branch December 27, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Relates to ESLint's documentation
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

None yet

2 participants