Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: FlatRuleTester -> RuleTester #17922

Merged
merged 4 commits into from Dec 29, 2023
Merged

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Dec 29, 2023

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[x] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

  1. Removed RuleTester
  2. Renamed FlatRuleTester to RuleTester
  3. Updated api.js to export the new RuleTester
  4. Updated unsupported-api.js to stop exporting FlatRuleTester
  5. Updated the API docs
  6. Updated the Migrate to v9 guide
  7. Updated all rule tests

Is there anything you'd like reviewers to focus on?

@nzakas nzakas requested a review from a team as a code owner December 29, 2023 19:12
@eslint-github-bot eslint-github-bot bot added breaking This change is backwards-incompatible feature This change adds a new feature to ESLint labels Dec 29, 2023
Copy link

netlify bot commented Dec 29, 2023

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit a2483b0
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/658f33d8e08f0f000862fdc7
😎 Deploy Preview https://deploy-preview-17922--docs-eslint.netlify.app/use/migrate-to-9.0.0
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

docs/src/use/migrate-to-9.0.0.md Outdated Show resolved Hide resolved
docs/src/use/migrate-to-9.0.0.md Outdated Show resolved Hide resolved
docs/src/use/migrate-to-9.0.0.md Outdated Show resolved Hide resolved
nzakas and others added 3 commits December 29, 2023 16:01
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit 946ae00 into main Dec 29, 2023
17 checks passed
@mdjermanovic mdjermanovic deleted the flat-rule-tester-rename branch December 29, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking This change is backwards-incompatible feature This change adds a new feature to ESLint
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

None yet

3 participants