Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Remove CodePath#currentSegments #17936

Merged
merged 3 commits into from Jan 1, 2024
Merged

feat!: Remove CodePath#currentSegments #17936

merged 3 commits into from Jan 1, 2024

Conversation

mdjermanovic
Copy link
Member

@mdjermanovic mdjermanovic commented Jan 1, 2024 •
edited

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[x] Add something to the core
[ ] Other, please explain:

fixes #17457

Removes CodePath#currentSegments along with associated deprecation warnings in RuleTester.

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

What was flat-rule-tester in 7f0e31f is now rule-tester.

@mdjermanovic mdjermanovic requested a review from a team as a code owner January 1, 2024 12:06
@eslint-github-bot eslint-github-bot bot added breaking This change is backwards-incompatible feature This change adds a new feature to ESLint labels Jan 1, 2024
@netlify Netlify
Copy link

netlify bot commented Jan 1, 2024 •
edited

✅ Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit fc1c987
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/6592b509c28c1400086a6839
😎 Deploy Preview https://deploy-preview-17936--docs-eslint.netlify.app/use/migrate-to-9.0.0
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mdjermanovic mdjermanovic marked this pull request as draft January 1, 2024 12:09
@mdjermanovic mdjermanovic added the core Relates to ESLint's core APIs and features label Jan 1, 2024
@mdjermanovic mdjermanovic marked this pull request as ready for review January 1, 2024 12:50
@mdjermanovic mdjermanovic mentioned this pull request Jan 1, 2024
Closed
1 task
nzakas
nzakas approved these changes Jan 1, 2024
View reviewed changes
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for picking this up.

@nzakas nzakas merged commit d191bdd into main Jan 1, 2024
17 checks passed
@nzakas nzakas deleted the remove-current-segments branch January 1, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nzakas nzakas nzakas approved these changes

Assignees
No one assigned
Labels
breaking This change is backwards-incompatible core Relates to ESLint's core APIs and features feature This change adds a new feature to ESLint
Projects
Triage
Status: Complete
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change Request: Deprecate and remove CodePath#currentSegments
2 participants
@mdjermanovic @nzakas