Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add more tests for ignoring files and directories #18018

Merged
merged 2 commits into from Jan 22, 2024
Merged

Conversation

mdjermanovic
Copy link
Member

@mdjermanovic mdjermanovic commented Jan 22, 2024

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

Refs #17964

What changes did you make? (Give an overview)

Added tests to confirm that the incorrect behavior of ignoring files and directories mentioned in #17964 (comment) has been fixed in eslint v9.0.0-alpha.1 by updating config-array dependency to v0.11.14 that includes humanwhocodes/config-array@9b3c72c bug fix.

Is there anything you'd like reviewers to focus on?

All added tests except the one from 82d754f were failing with config-array v0.11.13

@mdjermanovic mdjermanovic added accepted There is consensus among the team that this change meets the criteria for inclusion chore This change is not user-facing labels Jan 22, 2024
@mdjermanovic mdjermanovic requested a review from a team as a code owner January 22, 2024 10:51
Copy link

netlify bot commented Jan 22, 2024

Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit 82d754f
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/65ae6347cb52e70008532f2c

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@nzakas nzakas merged commit 8c1b8dd into main Jan 22, 2024
17 checks passed
@nzakas nzakas deleted the test-issue17964 branch January 22, 2024 17:54
snitin315 pushed a commit that referenced this pull request Feb 1, 2024
* test: add more tests for ignoring files and directories

Refs #17964

* add one more test

(cherry picked from commit 8c1b8dd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion chore This change is not user-facing
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

None yet

2 participants