feat!: no-unused-vars default caughtErrors to 'all'
#18043
Merged
+55
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint-github-bot
bot
added
breaking
✅ Deploy Preview for docs-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Could you change the docs too? |
|
D'oh, right, thanks. |
|
We need to mention this in the migration guide, where we have mentioned other breaking changes as well. |
mdjermanovic
added
the
accepted
bmish
reviewed
Jan 29, 2024
| @@ -33,6 +33,7 @@ The lists below are ordered roughly by the number of users each change is expect | |||
| * [`no-restricted-imports` now accepts multiple config entries with the same `name`](#no-restricted-imports) | |||
| * [`"eslint:recommended"` and `"eslint:all"` strings no longer accepted in flat config](#string-config) | |||
| * [`no-inner-declarations` has a new default behavior with a new option](#no-inner-declarations) | |||
| * [`no-unused-vars` now defaults `caughtErrors` to `"all"`](#no-unused-vars) | |||
There was a problem hiding this comment.
As an aside, it would be nice in a separate PR to group all default rule option changes together in this list or a sub-list.
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
amareshsm
reviewed
Jan 30, 2024
nzakas
approved these changes
Jan 31, 2024
Co-authored-by: Amaresh S M <amareshsm13@gmail.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[x] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Changes the default value for the
no-unused-varsrule'scaughtErrorsoption from"none"to"all".Fixes #17974.
Is there anything you'd like reviewers to focus on?