You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fasttime
added
rule
Relates to ESLint's core rules
accepted
There is consensus among the team that this change meets the criteria for inclusion
labels
Jan 30, 2024
issue #12048 is also about no-useless-computed-key rule, how about cover it too in this PR, if @mdjermanovic confirms that the behavior of the rule is correct.
issue #12048 is also about no-useless-computed-key rule, how about cover it too in this PR, if @mdjermanovic confirms that the behavior of the rule is correct.
I think it should be a separate PR as it isn't related to this option.
acceptedThere is consensus among the team that this change meets the criteria for inclusionbreakingThis change is backwards-incompatiblefeatureThis change adds a new feature to ESLintruleRelates to ESLint's core rules
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
eslint-github-bot
bot
added
breaking
fasttime
added
rule
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[X] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
Fixes #18042
What changes did you make? (Give an overview)
This PR changes the default value of the
enforceForClassMembersoption in theno-useless-computed-keyrule totrue.Since this is a breaking change in v9, I've updated the migration guide.
Is there anything you'd like reviewers to focus on?