refactor: remove globals dependency
#18115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-eslint canceled.
|
mdjermanovic
added
the
accepted
snitin315
reviewed
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:
Removes
globalsdependency.Since we extracted eslintrc logic into a separate package, the
globalsdependency was used only in two rules to get the list of ECMAScript globals. As we are already maintaining this list in eslint, there's no need for theglobalspackage as a direct production dependency.What changes did you make? (Give an overview)
astUtils.ECMASCRIPT_GLOBALS. It gets the latest ES globals fromconf/globals.no-constant-binary-expressionandno-extend-nativerules to useastUtils.ECMASCRIPT_GLOBALSinstead of theglobalspackage.globalsfrom dependencies and added it to devDependencies as we still need it in tests and ineslint.config.js. Also updated to the latest v14.0.0.Is there anything you'd like reviewers to focus on?