Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve error message for invalid rule config #18147

Merged
merged 2 commits into from Mar 1, 2024

Conversation

snitin315
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Fix #17364

Is there anything you'd like reviewers to focus on?

NA

@snitin315 snitin315 requested a review from a team as a code owner February 24, 2024 11:56
@eslint-github-bot eslint-github-bot bot added the bug ESLint is working incorrectly label Feb 24, 2024
@github-actions github-actions bot added the core Relates to ESLint's core APIs and features label Feb 24, 2024
Copy link

netlify bot commented Feb 24, 2024

Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit dcf5307
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/65dc8c4465ddd4000843eed6

@snitin315 snitin315 added the accepted There is consensus among the team that this change meets the criteria for inclusion label Feb 24, 2024
lib/config/rule-validator.js Outdated Show resolved Hide resolved
lib/config/rule-validator.js Outdated Show resolved Hide resolved
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! I'll leave this open for a few days in case anyone else wants to take a look before merging.

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks! (Also leaving open for a couple days so others can review if they'd like.)

@mdjermanovic mdjermanovic merged commit e37153f into main Mar 1, 2024
18 checks passed
@mdjermanovic mdjermanovic deleted the did-you-mean-message branch March 1, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly core Relates to ESLint's core APIs and features
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Change Request: Add "did you mean" for slightly incorrect rule option keys
3 participants