fix: constructor-super false positives with loops
#18226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdjermanovic
added
bug
✅ Deploy Preview for docs-eslint canceled.
|
mdjermanovic
commented
Mar 23, 2024
Comment on lines
-431
to
436
| } else if (isAnySegmentReachable(funcInfo.currentSegments)) { | ||
| context.report({ | ||
| messageId: "unexpected", | ||
| node | ||
| }); | ||
| } |
There was a problem hiding this comment.
This was intended to report super() calls in classes that don't have extends. But such calls already cause parsing errors so that's not something a rule can catch.
mdjermanovic
commented
Mar 23, 2024
Comment on lines
-355
to
+341
| segment => { | ||
| const info = segInfoMap[segment.id] ?? new SegmentInfo(); | ||
| (segment, controller) => { | ||
| const info = segInfoMap[segment.id]; | ||
|
|
||
| // skip segments after the loop | ||
| if (!info) { | ||
| controller.skip(); | ||
| return; | ||
| } |
There was a problem hiding this comment.
There's no need to traverse segments after the loop here.
mdjermanovic
commented
Mar 23, 2024
Comment on lines
-467
to
442
| /** | ||
| * Resets state. | ||
| * @returns {void} | ||
| */ | ||
| "Program:exit"() { | ||
| segInfoMap = Object.create(null); | ||
| } |
There was a problem hiding this comment.
I don't think there was any benefit from this.
mdjermanovic
commented
Mar 23, 2024
Comment on lines
343
to
+351
| const seenPrevSegments = segment.prevSegments.filter(hasSegmentBeenSeen); | ||
| const calledInSomePreviousPaths = seenPrevSegments.some(isCalledInSomePath); | ||
| const calledInEveryPreviousPaths = seenPrevSegments.every(isCalledInEveryPath); | ||
|
|
||
| // Updates flags. | ||
| info.calledInSomePaths = seenPrevSegments.some(isCalledInSomePath); | ||
| info.calledInEveryPaths = seenPrevSegments.every(isCalledInEveryPath); | ||
| info.calledInSomePaths ||= calledInSomePreviousPaths; | ||
| info.calledInEveryPaths ||= calledInEveryPreviousPaths; | ||
|
|
||
| // If flags become true anew, reports the valid nodes. | ||
| if (info.calledInSomePaths || isRealLoop) { | ||
| if (calledInSomePreviousPaths) { |
There was a problem hiding this comment.
This code that updates segments in loops was causing false positives. It didn't account for the case that the segment could have had a super() call inside the segment itself.
nzakas
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
Tell us about your environment (
npx eslint --env-info):What parser are you using (place an "X" next to just one item)?
[x]
Default (Espree)[ ]
@typescript-eslint/parser[ ]
@babel/eslint-parser[ ]
vue-eslint-parser[ ]
@angular-eslint/template-parser[ ]
OtherPlease show your full configuration:
Configuration
What did you do? Please include the actual source code causing the issue.
What did you expect to happen?
No errors as
super()is called in all paths.What actually happened? Please include the actual, raw output from ESLint.
What changes did you make? (Give an overview)
Fixed the problem in the code that handles loops. Also refactored some other parts of this rule. I'll leave comments on the code.
Is there anything you'd like reviewers to focus on?