Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Show config names in error messages #18256

Merged
merged 1 commit into from Apr 1, 2024
Merged

feat: Show config names in error messages #18256

merged 1 commit into from Apr 1, 2024

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Apr 1, 2024

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[x] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Updated @humanwhocodes/config-array so that we see config names in config validations errors.

fixes #18231
refs #18252

Is there anything you'd like reviewers to focus on?

@nzakas nzakas requested a review from a team as a code owner April 1, 2024 20:49
@eslint-github-bot eslint-github-bot bot added the feature This change adds a new feature to ESLint label Apr 1, 2024
Copy link

netlify bot commented Apr 1, 2024

Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit 0e268a2
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/660b1df535f6bb0008498c44

@mdjermanovic mdjermanovic added core Relates to ESLint's core APIs and features accepted There is consensus among the team that this change meets the criteria for inclusion labels Apr 1, 2024
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion core Relates to ESLint's core APIs and features feature This change adds a new feature to ESLint
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Support name field in flat config and recommend as an convention
2 participants