New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: version selectors synchronization #18260
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-eslint canceled.
|
mdjermanovic
added
build
This change relates to ESLint's build process
accepted
There is consensus among the team that this change meets the criteria for inclusion
labels
Apr 3, 2024
github-actions
bot
added
github actions
and removed
documentation
Relates to ESLint's documentation
labels
Apr 3, 2024
I think we should redirect it to |
nzakas
approved these changes
Apr 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and a lot more straightforward than what we've been doing.
Just leaving open a couple days to give others a chance to review.
This was referenced Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
accepted
There is consensus among the team that this change meets the criteria for inclusion
build
This change relates to ESLint's build process
documentation
Relates to ESLint's documentation
github actions
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:
Fixes #18229
Documentation & Build related.
What changes did you make? (Give an overview)
vNN.x
banchesmain
branch on GitHubIs there anything you'd like reviewers to focus on?
Changes in
docs/
should be ported to thev8.x
branch. Then, thelatest
branch should be updated.Question: What shall we do with
eslint.org/docs/next/
when we release v9 final? Keep it or remove it?