Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: @eslint-community/eslint-plugin-eslint-comments v4.3.0 #18319

Merged
merged 2 commits into from Apr 11, 2024

Conversation

mdjermanovic
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

Replaces eslint-plugin-eslint-comments with the latest version of @eslint-community/eslint-plugin-eslint-comments which provides a flat config export.

What changes did you make? (Give an overview)

Updated eslint-config-eslint.

Is there anything you'd like reviewers to focus on?

@mdjermanovic mdjermanovic requested a review from a team as a code owner April 11, 2024 12:00
@eslint-github-bot eslint-github-bot bot added the chore This change is not user-facing label Apr 11, 2024
@mdjermanovic mdjermanovic added the accepted There is consensus among the team that this change meets the criteria for inclusion label Apr 11, 2024
@mdjermanovic mdjermanovic changed the title chore: @eslint-community/eslint-plugin-eslint-comments v4.3.2 chore: @eslint-community/eslint-plugin-eslint-comments v4.3.0 Apr 11, 2024
Copy link

netlify bot commented Apr 11, 2024

Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit 867e923
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/6618365e30eb8800089029c2

@@ -374,11 +368,11 @@ const unicornConfigs = [{
}];

// extends eslint-plugin-eslint-comments's recommended config
const eslintCommentsConfigs = [eslintComments.configs.recommended, {
const eslintCommentsConfigs = [eslintCommentsPluginConfigs.recommended, {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The above comment needs to be updated too. :)

aladdin-add
aladdin-add previously approved these changes Apr 11, 2024
@mdjermanovic mdjermanovic merged commit a76fb55 into main Apr 11, 2024
18 checks passed
@mdjermanovic mdjermanovic deleted the eslint-plugin-eslint-comments-4.3.0 branch April 11, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion chore This change is not user-facing
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

None yet

2 participants