Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use @eslint/create-config latest #18373

Merged
merged 2 commits into from Apr 22, 2024
Merged

fix: use @eslint/create-config latest #18373

merged 2 commits into from Apr 22, 2024

Conversation

aladdin-add
Copy link
Member

@aladdin-add aladdin-add commented Apr 21, 2024

refs: #18369, #18361,

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

We've received a few reports generated configs seem to be eslintrc format, so I've updated the documentation to use the latest version.

Is there anything you'd like reviewers to focus on?

@eslint-github-bot eslint-github-bot bot added the documentation Relates to ESLint's documentation label Apr 21, 2024
@github-actions github-actions bot removed the documentation Relates to ESLint's documentation label Apr 21, 2024
Copy link

netlify bot commented Apr 21, 2024

Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit b6ed154
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/662604f78cb5220008c0cb84

@eslint-github-bot eslint-github-bot bot added the documentation Relates to ESLint's documentation label Apr 21, 2024
@github-actions github-actions bot removed the documentation Relates to ESLint's documentation label Apr 21, 2024
@aladdin-add aladdin-add changed the title docs: use @eslint/create-config latest fix: use @eslint/create-config latest Apr 21, 2024
@eslint-github-bot eslint-github-bot bot added the bug ESLint is working incorrectly label Apr 21, 2024
@aladdin-add aladdin-add marked this pull request as ready for review April 21, 2024 14:02
@aladdin-add aladdin-add requested a review from a team as a code owner April 21, 2024 14:02
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the console.warn on line 143 suggest to run npm init @eslint/config@latest?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated in b6ed154.

@aladdin-add aladdin-add added enhancement This change enhances an existing feature of ESLint accepted There is consensus among the team that this change meets the criteria for inclusion labels Apr 22, 2024
Copy link
Contributor

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! I'm fine with this solution.

@nzakas
Copy link
Member

nzakas commented Apr 22, 2024

I think we need to do a patch release with this PR merged.

@aladdin-add
Copy link
Member Author

Technically, it's not an eslint's issue; but it does appear that some users have encountered, so I'm 👍 .

@mdjermanovic mdjermanovic added the patch candidate This issue may necessitate a patch release in the next few days label Apr 22, 2024
Copy link
Member

@fasttime fasttime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fasttime fasttime merged commit a26b402 into main Apr 22, 2024
18 of 19 checks passed
@fasttime fasttime deleted the docs/init-latest branch April 22, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly enhancement This change enhances an existing feature of ESLint patch candidate This issue may necessitate a patch release in the next few days
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

None yet

5 participants