New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use @eslint/create-config latest #18373
Conversation
✅ Deploy Preview for docs-eslint canceled.
|
8305435
to
1993cdb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't the console.warn
on line 143 suggest to run npm init @eslint/config@latest
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated in b6ed154.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! I'm fine with this solution.
I think we need to do a patch release with this PR merged. |
Technically, it's not an eslint's issue; but it does appear that some users have encountered, so I'm 👍 . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
refs: #18369, #18361,
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
We've received a few reports generated configs seem to be eslintrc format, so I've updated the documentation to use the latest version.
Is there anything you'd like reviewers to focus on?