Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use @eslint/config-inspector@latest #18483

Merged
merged 2 commits into from
May 22, 2024

Conversation

aladdin-add
Copy link
Member

@aladdin-add aladdin-add commented May 22, 2024

like @eslint/create-config (#18369), it may use an outdated version, this commit forces to use the latest version.

fixes #18481

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ x] Other, please explain:

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

is there some other places need to be updated?

like @eslint/create-config (eslint#18369), it may use
an outdated version, this commit forces to use the latest version.

fixes eslint#18481
@aladdin-add aladdin-add requested a review from a team as a code owner May 22, 2024 04:11
@eslint-github-bot eslint-github-bot bot added the bug ESLint is working incorrectly label May 22, 2024
@github-actions github-actions bot added the cli Relates to ESLint's command-line interface label May 22, 2024
Copy link

netlify bot commented May 22, 2024

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit d2ecb81
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/664d9a2bd6a7590008dd002e
😎 Deploy Preview https://deploy-preview-18483--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aladdin-add aladdin-add added the accepted There is consensus among the team that this change meets the criteria for inclusion label May 22, 2024
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit 389744b into eslint:main May 22, 2024
20 checks passed
@aladdin-add aladdin-add deleted the issue18481 branch May 22, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly cli Relates to ESLint's command-line interface
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Bug: --inspect-config should always download the latest @eslint/config-inspector?
2 participants