Fix: api.markVariableAsUsed should check Node.js scope (fixes #2089) #2090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| found = markVariableAsUsedInScope(scope); | ||
|
|
||
| if (!found && scope.childScopes.length) { |
There was a problem hiding this comment.
This is overly aggressive because there's only one time when we want to check the first child. You really want to check if scope.type is "global" and only do this next step if that's true.
yannickcr
force-pushed
the
patch-used-variable
branch
from
01a2f4c
to
c921648
Compare
|
Has requested, I updated the condition to be less aggressive. |
yannickcr
force-pushed
the
patch-used-variable
branch
from
c921648
to
47fdfa6
Compare
yannickcr
force-pushed
the
patch-used-variable
branch
from
47fdfa6
to
294568f
Compare
| variables[i].eslintUsed = true; | ||
| return true; | ||
| found = false; | ||
|
|
There was a problem hiding this comment.
There's a much more appropriate change to make here. This could cause the wrong variable to be marked because it searches global and then node scope, which is the opposite of how variable resolution works.
Instead, this can be added to the original code just before the loop:
if (scope.type === "global" && currentConfig.ecmaFeatures.globalReturn) {
scope = scope.childScopes[0];
}
|
Closing in favor of #2121 |
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix very similar to the one you've done for #2064
I also added a test to reproduce the problem and fixed the getVariable helper to also check the Node.js scope.