Fix: vars-on-top conflict with ES6 import (fixes #2099) #2104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @returns {Boolean} whether the given node represents a import declaration | ||
| */ | ||
| function looksLikeImport(node) { | ||
| return node.type === "ImportDeclaration"; |
There was a problem hiding this comment.
ESTree split this up into multiple node types - see https://github.com/estree/estree/blob/master/es6.md#modules, though I don't recall whether Espree implements them yet. Should be able to check them all here for forward-compatibility even if they aren't parsed that way yet.
There was a problem hiding this comment.
Sounds good to me. I will have that implemented in few mins.
|
LGTM. |
nzakas
added a commit
that referenced
this pull request
Mar 18, 2015
Fix: vars-on-top conflict with ES6 import (fixes #2099)
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just checking for
importright now.Any others I should be looking at?