Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: newline-after-var to ignore declare in for specifiers (fixes #2317) #2323

Merged
merged 1 commit into from Apr 16, 2015
Merged

Fix: newline-after-var to ignore declare in for specifiers (fixes #2317) #2323

merged 1 commit into from Apr 16, 2015

Conversation

gyandeeps
Copy link
Member

No description provided.

@@ -41,6 +41,16 @@ module.exports = function(context) {
}

/**
* Determine if provided keyword is a variant of for specifiers
* @private
* @param {String} keyword - keyword to test
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lowercase "string" and "boolean", to differentiate from objects.

@gyandeeps
Copy link
Member Author

@nzakas I think now it should be good to go.

@nzakas
Copy link
Member

nzakas commented Apr 16, 2015

Looks good. Thanks!

nzakas added a commit that referenced this pull request Apr 16, 2015
Fix: newline-after-var to ignore declare in for specifiers (fixes #2317)
@nzakas nzakas merged commit 37725e4 into eslint:master Apr 16, 2015
@gyandeeps gyandeeps deleted the newline-after-var-fix branch April 16, 2015 15:58
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 7, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants