Fix: no-unused-vars had been crashed at /*global $*/
#3715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mysticatea
force-pushed
the
no-unused-vars/fix-crash-on-global-comment
branch
from
faa57da
to
cd5ce15
Compare
|
Wouldn't it be easier to replace regEx with something like: "[\n,\s]*(" + escape(variable.name) + ")[\n,\s]*" |
|
Hmm... I will think it more. |
mysticatea
force-pushed
the
no-unused-vars/fix-crash-on-global-comment
branch
from
cd5ce15
to
c4660d3
Compare
|
I updated! |
|
Yeah, that looks much better to me. Would want a second set of eyes on this though. |
|
LGTM |
nzakas
added a commit
that referenced
this pull request
Sep 10, 2015
…global-comment Fix: `no-unused-vars` had been crashed at `/*global $*/`
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3714.
\b(word boundary) could not be used to check boundaries if a variable name includes$at the edge.So I make checking manually with espree.