New: arrow-body-style rule (fixes #4109) #4144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, thank you @alberto ! |
|
Didn't you see #4109 (comment)? edit: Never mind, I see you opened this before that comment. |
|
@michaelficarra I'm not sure what you mean. I didn't include the other patterns I mentioned there. |
|
Sorry, I thought that comment was referring to the whole rule. |
|
LGTM. Going to hold off on merging in case we need another patch release. |
|
Great, thanks! |
|
Should this be |
|
Yeah, I like it better. @mysticatea? |
|
Yes, I like too. |
alberto
changed the title
|
This looks good to go. We're going to do one more patch release, then I think we can merge this. |
|
@nzakas just a reminder that this one is ready |
ilyavolodin
added a commit
that referenced
this pull request
Oct 26, 2015
New: arrow-body-style rule (fixes #4109)
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.