Do not implicitly cache package.json
#4610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, @SpainTrain! It looks like this is your first time contributing to ESLint, so please take a moment to read over our contribution guidelines. We'll also need you to sign our CLA, which is just a way for you to say that you give us permission to use your contribution. If you have any questions about the process, don't hesitate to ask. |
SpainTrain
force-pushed
the
dont-module-cache-package-json
branch
2 times, most recently
from
f8240dd
to
933cded
Compare
|
LGTM. |
|
@SpainTrain Thanks. Can you add a test that validates the change? |
SpainTrain
force-pushed
the
dont-module-cache-package-json
branch
from
933cded
to
836e8ee
Compare
* Read `package.json` on every config load by not using `require`
SpainTrain
force-pushed
the
dont-module-cache-package-json
branch
from
836e8ee
to
f912e21
Compare
|
✅ |
|
Awesome, thanks! |
nzakas
added a commit
that referenced
this pull request
Dec 5, 2015
Do not implicitly cache `package.json`
MethodGrab
added a commit
to MethodGrab/eslint
that referenced
this pull request
Jan 25, 2016
Read `.eslintrc.js` on every config load by not using `require` Related: eslint#4610
MethodGrab
added a commit
to MethodGrab/eslint
that referenced
this pull request
Jan 25, 2016
Read `.eslintrc.js` on every config load by not using `require` Related: eslint#4610
MethodGrab
added a commit
to MethodGrab/eslint
that referenced
this pull request
Jan 25, 2016
Read `.eslintrc.js` on every config load by not using `require` Related: eslint#4610
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently eslint will load the config stored in a project's package.json using
require. The downside to this is that the json is cached inrequire.cache. Thus, if eslint is executed twice in the same process, and the config has changed in the interim, it will not read the new config. For an example of this causing a downstream bug in the wild see AtomLinter/linter-eslint#349Closes #4611