Fix: crashed when SourceCode object was reused (fixes #5007) #5443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @nzakas, @gajus and @gyandeeps to be potential reviewers |
|
LGTM |
|
Nice! I think you can also remove estraverse-fb now. |
mysticatea
force-pushed
the
core/child-visitor-keys
branch
from
941b564
to
1da2420
Compare
|
True, I updated it. |
ilyavolodin
added a commit
that referenced
this pull request
Mar 2, 2016
Fix: crashed when SourceCode object was reused (fixes #5007)
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5007
escopehas supportedchildVisitorKeysoption, andestraversehas been supportingkeysoption.So no longer we need monkey patching for
escopeandestraverse.I made ESLint using those options.
Then I added a test case to verify we can reuse a source code object.