Fix: key-spacing checks ObjectExpression is multiline (fixes #5479) #5482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
@btmills Maybe you'll want to review this? I wasn't sure if I should add an assertion on node type (i.e., ensure |
|
LGTM. I don't think we need an assertion unless issues like this become more common. |
btmills
added a commit
that referenced
this pull request
Mar 5, 2016
Fix: key-spacing checks ObjectExpression is multiline (fixes #5479)
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty simple fix in the end, just needed to ensure the whole ObjectExpression was passed to the line count checker.