-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update: replace MD5 hashing of cache files with MurmurHash (fixes #5522) #5560
Conversation
LGTM |
Nice! LGTM. |
LGTM. @nzakas could you take a look? |
Can someone test this with |
FWIW, LGTM. On top of @nzakas comment a benchmark would perhaps also be interesting? |
Just ran this on a local code. Works perfectly fine when cache was created with current ESLint implementation and the next run is done with this PR. It basically just lints all files first time around. It's really tough to measure performance difference, since my sample code is small enough where running it with cache is actually slower then normal run. |
Just did a very unscientific benchmark on invoking
|
@michaelficarra can you rebase? |
@nzakas done. |
Update: replace MD5 hashing of cache files with MurmurHash (fixes #5522)
Fixes #5522. Removes the dependency on the
crypto
module, which is not available when node is built with the--without-ssl
flag.