Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: replace MD5 hashing of cache files with MurmurHash (fixes #5522) #5560

Merged
merged 1 commit into from
Mar 15, 2016

Conversation

michaelficarra
Copy link
Member

Fixes #5522. Removes the dependency on the crypto module, which is not available when node is built with the --without-ssl flag.

@eslintbot
Copy link

LGTM

@BYK
Copy link
Member

BYK commented Mar 13, 2016

Nice! LGTM.

@ilyavolodin
Copy link
Member

LGTM. @nzakas could you take a look?

@nzakas
Copy link
Member

nzakas commented Mar 13, 2016

Can someone test this with --cache, seeing what happens when you have an existing cache and then upgrade to this?

@jbergstroem
Copy link

FWIW, LGTM. On top of @nzakas comment a benchmark would perhaps also be interesting?

@ilyavolodin
Copy link
Member

Just ran this on a local code. Works perfectly fine when cache was created with current ESLint implementation and the next run is done with this PR. It basically just lints all files first time around. It's really tough to measure performance difference, since my sample code is small enough where running it with cache is actually slower then normal run.

@jbergstroem
Copy link

Just did a very unscientific benchmark on invoking time make lint in the nodejs repo five times with and without the patch. Looks like the switch was insignificant from a performance point of view. Results below:

timing crypto('md5') imurmurhash
fastest run 16.91s 16.62s
slowest run 18.01s 17.85s

@nzakas
Copy link
Member

nzakas commented Mar 15, 2016

@michaelficarra can you rebase?

@michaelficarra
Copy link
Member Author

@nzakas done.

nzakas added a commit that referenced this pull request Mar 15, 2016
Update: replace MD5 hashing of cache files with MurmurHash (fixes #5522)
@nzakas nzakas merged commit 87f8b18 into eslint:master Mar 15, 2016
@michaelficarra michaelficarra deleted the GH-5522 branch March 15, 2016 16:19
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants