Fix: Allow default ignored files to be unignored (fixes #5410) #5627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @gronke, @gyandeeps and @jrajav to be potential reviewers |
|
LGTM |
|
Looks good 👍 |
|
LGTM |
1 similar comment
|
LGTM |
nzakas
added a commit
that referenced
this pull request
Mar 22, 2016
Fix: Allow default ignored files to be unignored (fixes #5410)
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the default ignores from:
to:
as suggested by @alberto in #5410 (comment).
However, I'm keeping
this.ig.defaultso that we can continue avoiding showing warning messages for files in those folders.To allow custom-specified ignore patterns to override the defaults, the custom patterns will be added to the defaults as well. A warning will only be shown if a file is ignored by custom ignore rules but not by default.