Fix: object-shorthand should only lint computed methods (fixes #6015) #6024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
By analyzing the blame information on this pull request, we identified @lemonmade, @vitorbal and @nzakas to be potential reviewers |
|
LGTM 👍 |
|
LGTM |
|
Sorry for introducing this bug :( |
| @@ -109,7 +109,7 @@ module.exports = { | |||
| } | |||
|
|
|||
| // only computed methods can fail the following checks | |||
| if (!APPLY_TO_METHODS && node.computed) { | |||
| if ((!APPLY_TO_METHODS || node.value.type !== "FunctionExpression") && node.computed) { | |||
There was a problem hiding this comment.
I think you can drop the !APPLY_TO_METHODS check, the only computed case we care about is node.value.type === "FunctionExpression" && node.computed.
There was a problem hiding this comment.
That makes sense - thanks!
|
@lemonmade No need to apologize - it's part of the process of making things better :) |
|
LGTM |
|
Updated with @lemonmade's suggestion and added one more test |
|
Lgtm |
afc163
added a commit
to ant-design/ant-design
that referenced
this pull request
May 6, 2016
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.