Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Describe options in rules under Possible Errors part 2 #6063

Merged
merged 1 commit into from May 5, 2016

Conversation

pedrottimark
Copy link
Member

The next 10 rules under Possible Errors

  • Make description in h1 consistent with rules index page, not even the first word is capitalized. That is because will soon change the format to match the rules index page (that is, rule-id: rule description).
  • Make first sentence under Rule Details consistent with description.
  • Add “this rule with” to example sentences.
  • Describe options according to patterns in guidelines.

Here are additional changes:

  • no-empty-character-class: add Known Limitations; delete Related Rules link to removed rule
  • no-ex-assign: make examples parallel
  • no-extra-parens: add links to rules with potential conflicts which are ignored
  • no-irregular-whitespace: move examples from Rule Details to Options; change indent from 2 to 4
  • no-negated-in-lhs: rewrite introduction with analogy to incorrect numerical negation; remove Further Reading

@eslintbot
Copy link

LGTM

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @IanVS, @michaelficarra and @rhysd to be potential reviewers

@rhysd
Copy link
Contributor

rhysd commented May 4, 2016

LGTM for no-irregular-whitespace rule.

@ilyavolodin
Copy link
Member

LGTM

@nzakas nzakas merged commit 04563ca into master May 5, 2016
@pedrottimark pedrottimark deleted the docs-possible-errors-2 branch May 5, 2016 21:43
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants