Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Rule: no-constant-condition (fixes #621) #624

Merged
merged 2 commits into from
Feb 23, 2014
Merged

New Rule: no-constant-condition (fixes #621) #624

merged 2 commits into from
Feb 23, 2014

Conversation

makepanic
Copy link
Contributor

No description provided.

@@ -0,0 +1,75 @@
/**
* @fileoverview Rule to flag use constant conditions
* @author Christian
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Want to give yourself proper credit with a last name or website?

 - removed SwitchStatement discriminant check
 - removed AssignmentExpression with right Identifier
 - fixed copy paste error
 - added DoWhileStatement, ForStatement
based on discussion: #624
(fixes #621)
@nzakas
Copy link
Member

nzakas commented Feb 22, 2014

Lgtm

nzakas added a commit that referenced this pull request Feb 23, 2014
@nzakas nzakas merged commit 71a8cdd into eslint:master Feb 23, 2014
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 7, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants