Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Check strings in RegExp constructors for no-regex-spaces (fixes #3586) #6379

Merged
merged 1 commit into from Jun 28, 2016
Merged

Update: Check strings in RegExp constructors for no-regex-spaces (fixes #3586) #6379

merged 1 commit into from Jun 28, 2016

Conversation

jacksonrayhamilton
Copy link
Contributor

Fixes #3586, making it so a single string literal in a RegExp constructor is also checked for multiple consecutive spaces.

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @vitorbal, @pedrottimark and @alberto to be potential reviewers

@eslintbot
Copy link

Thanks for the pull request, @jacksonrayhamilton! I took a look to make sure it's ready for merging and found some changes are needed:

  • The commit summary must be 72 characters or shorter. Please check out our guide for how to properly format your commit summary and update it on this pull request.

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

@jquerybot
Copy link

Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA).

📝 Please visit http://contribute.jquery.org/CLA/ to sign.

After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know.


If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check.

@eslintbot
Copy link

LGTM

* @returns {void}
* @private
*/
function regexCheck(node, value) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rename each function to begin with "check"? Our conventions always have a verb as the first word in a function name.

@nzakas
Copy link
Member

nzakas commented Jun 15, 2016

The code looks read good, just one convention nitpick and otherwise lgtm.

@IanVS want to take a look?

@IanVS
Copy link
Member

IanVS commented Jun 18, 2016

LGTM, thanks @jacksonrayhamilton!

@eslintbot
Copy link

LGTM

@jacksonrayhamilton
Copy link
Contributor Author

Fixed the issue, glad to contribute.

@pedrottimark
Copy link
Member

Rule doc looks good to me

@nzakas
Copy link
Member

nzakas commented Jun 20, 2016

Just holding off on merging until we're sure we don't need another patch release.

@nzakas nzakas merged commit e2b2030 into eslint:master Jun 28, 2016
@nzakas
Copy link
Member

nzakas commented Jun 28, 2016

Thanks @jacksonrayhamilton !

@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants