Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Take type annotations into account in space-infix-ops #6519

Closed

Conversation

codepunkt
Copy link

@codepunkt codepunkt commented Jun 23, 2016

Test fails and i have no clue how i'm supposed to add babel-eslint to the testing stack for single tests.
Advice is welcome!

(fixes #5211)

Test fails and i have no clue how i'm supposed to add
`babel-eslint` to the testing stack for single tests.
@eslintbot
Copy link

Thanks for the pull request, @gonsfx! I took a look to make sure it's ready for merging and found some changes are needed:

  • Pull requests with code require an issue to be mentioned at the end of the commit summary, such as (fixes #1234). Please update the commit summary with an issue (file a new issue if one doesn't already exist).

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @gyandeeps, @vitorbal and @michaelficarra to be potential reviewers

@jquerybot
Copy link

Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA).

📝 Please visit http://contribute.jquery.org/CLA/ to sign.

After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know.


If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check.

@codepunkt codepunkt changed the title Update: Fix #226, adjust space-infix-ops Update: Adjust space-infix-ops rule to take flow annotations into account Jun 23, 2016
@codepunkt codepunkt changed the title Update: Adjust space-infix-ops rule to take flow annotations into account Update: Take type annotations into account in space-infix-ops Jun 23, 2016
@platinumazure
Copy link
Member

One possible path forward:

  1. Look at package.json in the root project directory and see if "babel-eslint" shows up as a devDependency.
  2. If not, add it and run npm install.
  3. Then see if you can change the parser using a RuleTester option.

FYI: I'm not 100% sure RuleTester lets you change the parser- it's the sort of thing plugin authors would need but core rule developers wouldn't, so I don't know if we ever did that.

@michaelficarra
Copy link
Member

This doesn't seem to have anything to do with #226. Did you mean to open this PR against a different repo?

@codepunkt
Copy link
Author

codepunkt commented Jun 23, 2016

@michaelficarra Thanks. No clue what happened here, but i fixed it.

@platinumazure Thanks for your feedback!

I have babel-eslint installed as a devDependency but i wasn't sure if and how to set it using a RuleTester option.

Also, i'm not sure if this should be implemented in eslint at all - it could probably also be done in eslint-plugin-babel.

@nzakas
Copy link
Member

nzakas commented Jun 25, 2016

@gonsfx you should be able to set parser for an individual test just like you do other options.

@alberto
Copy link
Member

alberto commented Jun 30, 2016

@gonsfx If you want to pull babel-eslint, you have to add it to our package.json devDependencies

To use it, add parser: "babel-eslint" to your test object.

@nzakas
Copy link
Member

nzakas commented Jul 9, 2016

@gonsfx are you going to finish this up?

@nzakas
Copy link
Member

nzakas commented Jul 20, 2016

Carried over to #6723.

@nzakas nzakas closed this Jul 20, 2016
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flow type triggers space-infix-ops error
8 participants