New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update: Take type annotations into account in space-infix-ops
#6519
Conversation
Test fails and i have no clue how i'm supposed to add `babel-eslint` to the testing stack for single tests.
Thanks for the pull request, @gonsfx! I took a look to make sure it's ready for merging and found some changes are needed:
Can you please update the pull request to address these? (More information can be found in our pull request guide.) |
By analyzing the blame information on this pull request, we identified @gyandeeps, @vitorbal and @michaelficarra to be potential reviewers |
Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA). 📝 Please visit http://contribute.jquery.org/CLA/ to sign. After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know. If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check. |
space-infix-ops
space-infix-ops
rule to take flow annotations into account
space-infix-ops
rule to take flow annotations into accountspace-infix-ops
One possible path forward:
FYI: I'm not 100% sure RuleTester lets you change the parser- it's the sort of thing plugin authors would need but core rule developers wouldn't, so I don't know if we ever did that. |
This doesn't seem to have anything to do with #226. Did you mean to open this PR against a different repo? |
@michaelficarra Thanks. No clue what happened here, but i fixed it. @platinumazure Thanks for your feedback! I have Also, i'm not sure if this should be implemented in |
@gonsfx you should be able to set |
@gonsfx If you want to pull To use it, add |
@gonsfx are you going to finish this up? |
Carried over to #6723. |
Test fails and i have no clue how i'm supposed to add
babel-eslint
to the testing stack for single tests.Advice is welcome!
(fixes #5211)