Update: no-unused-vars ignores read it modifies itself (fixes #6348)
#6535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
`no-unused-vars` comes to ignore a read of a modification of itself. - A read in RHS of an assignment to itself (e.g. `a = a + 1`) - A read in LHS of an assignment (e.g. `a += 1`) - Increments/Decrements (e.g. `a++`) Those are ignored only if those exist at the direct child of an ExpressionStatement node. This is in order to avoid false positive such `foo(a = a + 1)`
|
LGTM |
|
2nd commit is removing 2 unused variables in our repo. Those were found newly by this fix. 😉 |
|
Nice, LGTM |
| {code: "var a = 0, b; b = a++; foo(b);"}, | ||
| {code: "function foo(a) { var b = a = a + 1; bar(b) } foo();"}, | ||
| {code: "function foo(a) { var b = a += a + 1; bar(b) } foo();"}, | ||
| {code: "function foo(a) { var b = a++; bar(b) } foo();"} |
There was a problem hiding this comment.
Can we have test cases for something like:
var a = 2;
a = a * 5 + 6;Should this pass?
Also,
var a = 2, b = 4;
a = a * 2 + b; // b should count as used hereIf these tests exist already, my apologies, I only read the diff.
There was a problem hiding this comment.
Thank you!
I added suggested tests.
|
LGTM |
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6348.
no-unused-varscomes to ignore a read of a modification of itself.a = a + 1)a += 1)a++)Those are ignored only if those exist at the direct child of an
ExpressionStatement node. This is in order to avoid false positive such
foo(a = a + 1)