Fix: Do not throw exception if baseConfig is provided (fixes #6605) #6625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
LGTM 👍 |
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue does this pull request address?
When using CLIEngine, specifying baseConfig was not enough to prevent a No Config Found exception from being thrown. This change will ensure that no exception is thrown if baseConfig is provided to CLIEngine.
What changes did you make? (Give an overview)
Check if baseConfig is present in lib/config.js before throwing an exception, plus test, plus change to migration guide.
Is there anything you'd like reviewers to focus on?
Not 100% sure if baseConfig should be checked for at least one key, like "rules" is. Assumption is that baseConfig is null/undefined by default, and so an empty object still represents a conscious user decision to provide a config (even if empty). If this is a bad assumption, let me know.