Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Fix multiline-ternary typos #6704

Merged
merged 1 commit into from Jul 18, 2016
Merged

Docs: Fix multiline-ternary typos #6704

merged 1 commit into from Jul 18, 2016

Conversation

cmalard
Copy link
Contributor

@cmalard cmalard commented Jul 18, 2016

No description provided.

@mention-bot
Copy link

@cmalard, thanks for your PR! By analyzing the annotation information on this pull request, we identified @kaicataldo to be a potential reviewer

@eslintbot
Copy link

LGTM

@jquerybot
Copy link

Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA).

📝 Please visit http://contribute.jquery.org/CLA/ to sign.

After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know.

If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check.

@kaicataldo
Copy link
Member

kaicataldo commented Jul 18, 2016 •
edited

Thanks for catching these and for contributing! A few housekeeping things and we can get this merged. If you haven't already, please sign the jQuery CLA mentioned by the bot above. For the commit description, mind referencing which docs you're fixing? i.e. Docs: Fix multiline-ternary typos.

@eslintbot
Copy link

LGTM

@eslintbot
Copy link

LGTM

@cmalard cmalard changed the title Docs: fix example typo, wrong url Docs: Fix multiline-ternary typo Jul 18, 2016
@eslintbot
Copy link

LGTM

@cmalard cmalard changed the title Docs: Fix multiline-ternary typo Docs: Fix multiline-ternary typos Jul 18, 2016
@cmalard
Copy link
Contributor Author

cmalard commented Jul 18, 2016

:-D

@kaicataldo
Copy link
Member

Thanks!

@kaicataldo kaicataldo merged commit f916ae5 into eslint:master Jul 18, 2016
@kaicataldo
Copy link
Member

LGTM. Thanks for contributing to ESLint!

@cmalard cmalard deleted the fix-multiline-ternary branch July 18, 2016 20:57
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cmalard @mention-bot @eslintbot @jquerybot @kaicataldo