New: no-tabs rule (fixes #6079)
#6772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gyandeeps, thanks for your PR! By analyzing the annotation information on this pull request, we identified @nzakas, @alberto and @kaicataldo to be potential reviewers |
|
LGTM |
|
| @@ -0,0 +1,37 @@ | |||
| # Disallow tabs in file (no-tabs) | |||
|
|
|||
| Some people prefer whitespaces instead of tab characters in a file. So they would want to disallow tab anywhere inside a file including comments. | |||
There was a problem hiding this comment.
Tabs are also whitespace. Better to say that some style guides don't allow the use of tab characters anywhere.
|
I'm 👍 fit adding to our config. Dogfood all the things! |
| column: match.index + 1 | ||
| }, | ||
| "Line has tabs." | ||
| ); |
|
LGTM |
|
All the changes have been made. |
|
LGTM |
|
Lgtm |
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue does this pull request address?
New rule named
no-tabsWhat changes did you make? (Give an overview)
created a new rule.
Is there anything you'd like reviewers to focus on?
nothing specific
Need suggestions on: