Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: clarify rule details for no-template-curly-in-string #6900

Merged
merged 1 commit into from Aug 15, 2016

Conversation

not-an-aardvark
Copy link
Member

What issue does this pull request address? N/A (docs update)

What changes did you make? (Give an overview)

This clarifies the documentation for the no-template-curly-in-string rule. Escaping the quotes in the description makes it seem like the rule might be looking for actual escaped quotes in the string, when it is simply looking for quotes surrounding the string.

Is there anything you'd like reviewers to focus on? No

@mention-bot
Copy link

@not-an-aardvark, thanks for your PR! By analyzing the annotation information on this pull request, we identified @jfmengels to be a potential reviewer

@eslintbot
Copy link

LGTM

@platinumazure
Copy link
Member

LGTM, just waiting for others to review.

@platinumazure platinumazure merged commit 02a00d6 into eslint:master Aug 15, 2016
@not-an-aardvark not-an-aardvark deleted the clarify-template-docs branch March 23, 2017 16:23
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants