Fix: false negative of indent with else if statements (fixes #6956)
#6965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
Nice. |
| "if (baz) foobar();\n" + | ||
| "else qux();", | ||
| options: [2], | ||
| errors: expectedErrors([[2, 0, 2, "IfStatement"], [3, 0, 2, "Keyword"]]) |
There was a problem hiding this comment.
Could you add some tests for when the if/else expression has braces as well?
|
LGTM, except for one suggestion to add some additional tests. |
not-an-aardvark
force-pushed
the
issue6956
branch
from
4c56f0c
to
b409ca9
Compare
|
LGTM |
|
Added a few more tests. |
|
LGTM. @vitorbal What do you think of the new tests? |
|
Thanks, @not-an-aardvark! LGTM as well. |
|
LGTM. Thanks for contributing, @not-an-aardvark |
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue does this pull request address?
#6956
What changes did you make? (Give an overview)
Previously, only the first
elsestatement in a chain would be checked for correct indentation. This PR fixes the issue by recursively checking nodes inelse ifchains to ensure that all nodes have the right indentation.Is there anything you'd like reviewers to focus on?
Nothing in particular.