Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: no-regex-spaces uses internal rule message format (fixes #7052) #7053

Merged
merged 1 commit into from Sep 3, 2016

Conversation

platinumazure
Copy link
Member

What issue does this pull request address?

Issue #7052

What changes did you make? (Give an overview)

no-regex-spaces now uses internal rule message formatting. (This was previously blocked until #7041 was merged.)

Is there anything you'd like reviewers to focus on?

Nah, should be pretty self-explanatory.

@mention-bot
Copy link

@platinumazure, thanks for your PR! By analyzing the annotation information on this pull request, we identified @jacksonrayhamilton, @vitorbal and @mduvall to be potential reviewers

@eslintbot
Copy link

LGTM

@vitorbal
Copy link
Member

vitorbal commented Sep 3, 2016

LGTM, waiting a couple more days for others to take a look though!

@platinumazure
Copy link
Member Author

Thanks! FYI, no waiting period necessary on chore PRs (but wanting a second set of eyes is totally fine!).

@vitorbal
Copy link
Member

vitorbal commented Sep 3, 2016

Oh, thanks for reminding me! In that case I think this is straightforward enough so I'm gonna just merge.

@vitorbal vitorbal merged commit fa760f9 into master Sep 3, 2016
@platinumazure platinumazure deleted the chore-fix-no-regex-spaces branch September 6, 2016 17:34
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants