Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Fix examples for no-restricted-properties #7099

Merged

Conversation

not-an-aardvark
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[x] Documentation update
[ ] Bug fix ([template](https://github.com/eslint/eslint/blob/master/templates/bug-report.md))
[ ] New rule ([template](https://github.com/eslint/eslint/blob/master/templates/rule-proposal.md))
[ ] Changes an existing rule ([template](https://github.com/eslint/eslint/blob/master/templates/rule-change-proposal.md))
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

If the item you've check above has a template, please paste the template questions here and answer them.

Please check each item to ensure your pull request is ready:

  • I've read the pull request guide
  • (n/a) I've included tests for my change
  • I've updated documentation for my change (if appropriate)

What changes did you make? (Give an overview)

This fixes the example configuration for no-restricted-properties. The current example is invalid and causes ESLint to exit with an error when used.

Is there anything you'd like reviewers to focus on?

Nothing in particular.

@mention-bot
Copy link

@not-an-aardvark, thanks for your PR! By analyzing the annotation information on this pull request, we identified @TheSavior to be a potential reviewer

@eslintbot
Copy link

LGTM

@TheSavior
Copy link
Contributor

Whoops. LGTM.

@platinumazure
Copy link
Member

LGTM. (I'm just checking with the team to make sure we can merge this even if we might have a patch release next Monday.)

@platinumazure
Copy link
Member

Thanks for the PR, @not-an-aardvark!

@platinumazure platinumazure merged commit 58e6d76 into eslint:master Sep 10, 2016
@not-an-aardvark not-an-aardvark deleted the fix-no-restricted-properties-docs branch September 10, 2016 00:42
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants