Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: line-comment-position "above" string option now works (fixes #7100) #7102

Merged
merged 1 commit into from Sep 13, 2016

Conversation

platinumazure
Copy link
Member

@platinumazure platinumazure commented Sep 10, 2016

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[x] Bug fix ([template](https://github.com/eslint/eslint/blob/master/templates/bug-report.md))
[ ] New rule ([template](https://github.com/eslint/eslint/blob/master/templates/rule-proposal.md))
[ ] Changes an existing rule ([template](https://github.com/eslint/eslint/blob/master/templates/rule-change-proposal.md))
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

Re: bug report template: See issue #7100.

Please check each item to ensure your pull request is ready:

  • I've read the pull request guide
  • I've included tests for my change
  • I've updated documentation for my change (if appropriate)

What changes did you make? (Give an overview)

Added test case given in #7100, and fixed the typo in the rule.

Is there anything you'd like reviewers to focus on?

Not really, this should be pretty straightforward.

I do have a question about whether I should include test cases for things like // jscs:disable being beside code with "above" option. I don't know if that case makes sense inline, though (i.e., I know jscs:disable applies to the next line, but maybe there are other cases that should be tested).

@mention-bot
Copy link

@platinumazure, thanks for your PR! By analyzing the annotation information on this pull request, we identified @alberto to be a potential reviewer

@eslintbot
Copy link

LGTM

@mysticatea
Copy link
Member

LGTM but would like someone else to verify.

@platinumazure
Copy link
Member Author

@mysticatea Thanks! I just came up with a question for reviewers after you reviewed-- sorry! The question is:

I do have a question about whether I should include test cases for things like // jscs:disable being beside code with "above" option. I don't know if that case makes sense inline, though (i.e., I know jscs:disable applies to the next line, but maybe there are other cases that should be tested).

Please let me know if your opinion changes based on that question. Thanks!

@kaicataldo
Copy link
Member

LGTM

@mysticatea
Copy link
Member

LGTM since this PR addresses #7100. But it's always good if there are more tests.

@kaicataldo
Copy link
Member

Thanks for contributing!

@kaicataldo kaicataldo merged commit afd132a into master Sep 13, 2016
@platinumazure platinumazure deleted the issue7100 branch September 24, 2016 04:54
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants