Fix: line-comment-position "above" string option now works (fixes #7100) #7102
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
Re: bug report template: See issue #7100.
Please check each item to ensure your pull request is ready:
What changes did you make? (Give an overview)
Added test case given in #7100, and fixed the typo in the rule.
Is there anything you'd like reviewers to focus on?
Not really, this should be pretty straightforward.I do have a question about whether I should include test cases for things like
// jscs:disable
being beside code with "above" option. I don't know if that case makes sense inline, though (i.e., I know jscs:disable applies to the next line, but maybe there are other cases that should be tested).