Update: keyword-spacing
supports async/await (refs #7101)
#7179
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
Tell us about your environment
What parser (default, Babel-ESLint, etc.) are you using?
Please show your full configuration:
What did you do? Please include the actual source code causing the issue.
What did you expect to happen?
async
contextual keyword.What actually happened? Please include the actual, raw output from ESLint.
Please check each item to ensure your pull request is ready:
What changes did you make? (Give an overview)
This PR fixes
keyword-spacing
rule to handle async/await contextual keywords.Semver-minor
: this is a bug fix which increases errors.Is there anything you'd like reviewers to focus on?
There is the discussion about which rule should handle the space of between
async
and function-paren: #7101 (comment)In this PR,
keyword-spacing
does not handle the space since I preferred consistency #7101 (comment)