Fix: arrow-parens supports type annotations (fixes #7406)
#7436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mysticatea
added
bug
|
@mysticatea, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nfroidure, @vitorbal and @not-an-aardvark to be potential reviewers. |
|
LGTM |
This was referenced Oct 24, 2016
|
Just a heads up: we have moved to a new CLA checker on pull requests. Even if you've previously signed our CLA, we will need to you sign the new one. To do so, look at the status checks for licence/cla and click the "Details" link. Sorry for the inconvenience. |
|
Any idea when this'll make it into a release? :) |
|
@joemckie We usually do release every two weeks on Friday. So this PR will be released today. |
|
Awesome, thank you! |
christophehurpeau
added a commit
to christophehurpeau/eslint-config-pob
that referenced
this pull request
May 14, 2017
BREAKING CHANGE: enabled rule arrow-parens
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[X] Bug fix (template)
See #7406 for the template.
What changes did you make? (Give an overview)
If there is a type annotation, we cannot remove parentheses around parameters of arrow functions. But
arrow-parenshas warned those.This PR fixes the bug.
I generated the ASTs with type annotations by http://astexplorer.net/
Is there anything you'd like reviewers to focus on?
Nothing in particular.