Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade: Shelljs to ^0.7.5 (fixes #7316) #7465

Merged
merged 1 commit into from Oct 28, 2016
Merged

Upgrade: Shelljs to ^0.7.5 (fixes #7316) #7465

merged 1 commit into from Oct 28, 2016

Conversation

gyandeeps
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Upgraded shelljs to ^0.7.0 from ^0.6.0.
Made a change in unit test fixture setup due to a breaking change to cp function.
Docs: https://github.com/shelljs/shelljs/wiki/Migrating-from-v0.6-to-v0.7#breaking-changes (4th point)

Is there anything you'd like reviewers to focus on?

Nothing special

@eslintbot
Copy link

LGTM

@mention-bot
Copy link

@gyandeeps, thanks for your PR! By analyzing the history of the files in this pull request, we identified @IanVS, @mysticatea and @nzakas to be potential reviewers.

Copy link
Member

@not-an-aardvark not-an-aardvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

It doesn't really matter, but I think you have an extra ) in the commit message.

@gyandeeps
Copy link
Member Author

mock-fs release 3.12.0 broke master. Everything is fine for 3.11.0
Issue created because of this change: tschaub/mock-fs#141

@eslintbot
Copy link

LGTM

@eslintbot
Copy link

LGTM

@platinumazure platinumazure changed the title Upgrade: Shelljs to ^0.7.5 (fixes #7316)) Upgrade: Shelljs to ^0.7.5 (fixes #7316) Oct 28, 2016
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@kaicataldo kaicataldo merged commit fe0d903 into master Oct 28, 2016
@gyandeeps gyandeeps deleted the issue7316 branch October 28, 2016 15:16
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants