-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade: Shelljs to ^0.7.5 (fixes #7316) #7465
Conversation
LGTM |
@gyandeeps, thanks for your PR! By analyzing the history of the files in this pull request, we identified @IanVS, @mysticatea and @nzakas to be potential reviewers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
It doesn't really matter, but I think you have an extra )
in the commit message.
|
LGTM |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Upgraded
shelljs
to^0.7.0
from^0.6.0
.Made a change in unit test fixture setup due to a breaking change to
cp
function.Docs: https://github.com/shelljs/shelljs/wiki/Migrating-from-v0.6-to-v0.7#breaking-changes (4th point)
Is there anything you'd like reviewers to focus on?
Nothing special