Fix: syntax error after key-spacing autofix with comment (fixes #7603)
#7607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not-an-aardvark
added
accepted
|
LGTM |
|
@not-an-aardvark, thanks for your PR! By analyzing the history of the files in this pull request, we identified @RRMoelker, @btmills and @Kyle-Mendes to be potential reviewers. |
btmills
approved these changes
Nov 15, 2016
|
LGTM |
|
@platinumazure There are now! 😃 |
ilyavolodin
approved these changes
Nov 15, 2016
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[x] Bug fix (template)
#7603
What changes did you make? (Give an overview)
This updates the
key-spacingautofixer to be aware of comments. Previously, it would remove whitespace from the token before/after the colon, but if there was a comment between the token and the colon, it would remove text from the edge of the comment instead, causing a syntax error.Is there anything you'd like reviewers to focus on?
Nothing in particular.