New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: no-obj-calls does not report errors for Reflect (fixes #7700) #7710
Fix: no-obj-calls does not report errors for Reflect (fixes #7700) #7710
Conversation
@techeverri, thanks for your PR! By analyzing the history of the files in this pull request, we identified @pedrottimark, @vitorbal and @ilyavolodin to be potential reviewers. |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pull request!
The code changes look good to me, but would you mind making a couple changes to the commit message?
- Since this is a bugfix that would cause more errors to be reported, the commit message should start with
Update:
instead ofFix:
. - I think you might have forgotten the word
Reflect
at the end of the commit message (at the moment it's justno-obj-calls does not report errors for
Alternatively, we can update the commit message when we merge this pull request.
LGTM |
@not-an-aardvark commit message updated :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This looks good to me.
We generally keep pull requests open for at least 2 days before merging them in case anyone else on the team has changes to suggest, so this will probably be merged sometime relatively soon unless anything unexpected comes up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Thanks for contributing to ESLint! |
What is the purpose of this pull request?
[x] Bug fix
See #7700
What changes did you make?
I updated
no-obj-calls
to account for the new globalReflect
introduced in ECMAScript 2015. This reports an error about the Reflect() call, because it's a global object property and not a function.Is there anything you'd like reviewers to focus on?
Nothing in particular