Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config-file): add alternative property name for config #7800

Closed
wants to merge 3 commits into from
Closed

feat(config-file): add alternative property name for config #7800

wants to merge 3 commits into from

Conversation

Scrum
Copy link

@Scrum Scrum commented Dec 20, 2016

What is the purpose of this pull request? (put an "X" next to item)

[x] Add something to the core

What changes did you make? (Give an overview)

Add alternative property name for config in package.json. - eslint
Now you can use eslint in package.json to configure.

Is there anything you'd like reviewers to focus on?

Nothing in particular.

@jsf-clabot
Copy link

jsf-clabot commented Dec 20, 2016

CLA assistant check
All committers have signed the CLA.

@eslintbot
Copy link

Thanks for the pull request, @gitscrum! I took a look to make sure it's ready for merging and found some changes are needed:

  • The commit summary needs to begin with a tag (such as Fix: or Update:). Please check out our guide for how to properly format your commit summary and update it on this pull request.

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

@mention-bot
Copy link

@gitscrum, thanks for your PR! By analyzing the history of the files in this pull request, we identified @SpainTrain, @not-an-aardvark and @nzakas to be potential reviewers.

@vitorbal vitorbal added core Relates to ESLint's core APIs and features enhancement This change enhances an existing feature of ESLint evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Dec 20, 2016
@platinumazure
Copy link
Member

@gitscrum Thanks for the pull request.

Can you please explain what problem this is solving?

@Scrum
Copy link
Author

Scrum commented Dec 21, 2016

@platinumazure Hi

Can you please explain what problem this is solving?

I'm creating collector configurations and see some tacit agreement in such packages as babel, ava, stylelint, eslint all have roughly similar structure configuration { ...options, plugins: {...}, extends: {} }, babel { ...options, plugins: {...}, extends: {...}, presets: {...} }.

The naming of the packages is almost identical with the semantic logic configuration babel-plugin-array-includes, babel-preset-babili where babel is the package name matches the name in the configuration.

"devDependencies": {
  "babel-plugin-array-includes": "^2.0.3",
  "babel-preset-babili": "0.0.9"
},
"babel": {
  "preset": [ ... ],
  "plugins": [ ... ]
}

Based on this understanding I want in the future to create some guidelines for choosing the package names and create Linter ))

@nzakas
Copy link
Member

nzakas commented Dec 25, 2016

This was brought up a while ago and we decided not to make such a change. Discussion: #2670

I don't see a good reason to revisit that decision.

@Scrum
Copy link
Author

Scrum commented Dec 25, 2016

What for you is good for others may be unacceptable.
Explain why eslintConfig ? There are some reasons why you that critical ?

@nzakas
Copy link
Member

nzakas commented Dec 26, 2016

@gitscrum all we are talking about is what the key of a JSON structure is, I'm not sure how such a decision could be considered unacceptable. I already linked to the previous discussion, but just to be clear: we've had this for a long time and there's no good reason to change it. Personal preference is not a good reason to either break existing users or introduce a second way of doing the same thing.

I'm sorry that you disagree, however, I don't see any reason to revisit this decision. We have a lot of existing users we need to think about.

@nzakas nzakas closed this Dec 26, 2016
@Scrum
Copy link
Author

Scrum commented Dec 27, 2016

@nzakas

we've had this for a long time and there's no good reason to change it.

The base was provided above, as I wrote, I create a collector configuration which is based on [name-pkg]-[type/method]-[name]. But I didn't change but only provided an alternative method

Personal preference is not a good reason

Personal preference is when one person changes something for their inner/hidden project. In this case, we have more than one and my goal is open and described above.

we've had this for a long time.

Do not think this argument why are you using eslintConfig and why it is critical for you.

I'm not sure how such a decision could be considered unacceptable.

Do you think that adding alternative methods and giving in fact a single method will allow you to
understand it ? Are you serious ?

I'm sorry that you disagree, however, I don't see any reason to revisit this decision.

Don't be sorry, I did everything possible to improve your very best package, only your horizon is used to determine the future for this.

@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion core Relates to ESLint's core APIs and features enhancement This change enhances an existing feature of ESLint evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants