-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(config-file): add alternative property name for config #7800
Conversation
Thanks for the pull request, @gitscrum! I took a look to make sure it's ready for merging and found some changes are needed:
Can you please update the pull request to address these? (More information can be found in our pull request guide.) |
@gitscrum, thanks for your PR! By analyzing the history of the files in this pull request, we identified @SpainTrain, @not-an-aardvark and @nzakas to be potential reviewers. |
@gitscrum Thanks for the pull request. Can you please explain what problem this is solving? |
I'm creating collector configurations and see some tacit agreement in such packages as The naming of the packages is almost identical with the semantic logic configuration "devDependencies": {
"babel-plugin-array-includes": "^2.0.3",
"babel-preset-babili": "0.0.9"
},
"babel": {
"preset": [ ... ],
"plugins": [ ... ]
} Based on this understanding I want in the future to create some guidelines for choosing the package names and create Linter )) |
This was brought up a while ago and we decided not to make such a change. Discussion: #2670 I don't see a good reason to revisit that decision. |
What for you is good for others may be unacceptable. |
@gitscrum all we are talking about is what the key of a JSON structure is, I'm not sure how such a decision could be considered unacceptable. I already linked to the previous discussion, but just to be clear: we've had this for a long time and there's no good reason to change it. Personal preference is not a good reason to either break existing users or introduce a second way of doing the same thing. I'm sorry that you disagree, however, I don't see any reason to revisit this decision. We have a lot of existing users we need to think about. |
The base was provided above, as I wrote, I create a collector configuration which is based on [name-pkg]-[type/method]-[name]. But I didn't change but only provided an alternative method
Personal preference is when one person changes something for their inner/hidden project. In this case, we have more than one and my goal is open and described above.
Do not think this argument why are you using eslintConfig and why it is critical for you.
Do you think that adding alternative methods and giving in fact a single method will allow you to
Don't be sorry, I did everything possible to improve your very best package, only your horizon is used to determine the future for this. |
What is the purpose of this pull request? (put an "X" next to item)
[x] Add something to the core
What changes did you make? (Give an overview)
Add alternative property name for config in
package.json
. -eslint
Now you can use
eslint
inpackage.json
to configure.Is there anything you'd like reviewers to focus on?
Nothing in particular.