-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update: rewrite TokenStore (fixes #7810) #7936
Merged
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
8bab6f6
Update: rewrite TokenStore (fixes #7810)
mysticatea e306942
Chore: refactor with new API
mysticatea c031e0d
Docs: update working-with-rules.md
mysticatea 3061734
Fix: improve tests
mysticatea 4913c93
Chore: simplify `isNot*` functions
mysticatea 7c81030
Chore: fix jsdoc comments.
mysticatea 7f51920
Fix: `isComment` returns true for shebang
mysticatea fa213b5
Chore: remove unnecessary `isOfToken` function
mysticatea 24505a8
Chore: refactor TokenStore; remove `movePrev` methods
mysticatea e75803f
Chore: rename variables: start, end, imap
mysticatea ec714db
Fix: this.predicate() → predicate()
mysticatea 5beeb9d
Chore: typeof → in
mysticatea 5d05c23
Chore: use lodash.sortedIndexBy
mysticatea 7c2b8c5
Chore: update jsdoc comments
mysticatea 8b95583
Docs: add a note for skip & filter
mysticatea 587ef0d
Chore: fix typo
mysticatea 1133196
Chore: fix "Block" to `.startsWith("Block")`
mysticatea 66ee5bf
Docs: add compatibility notes to JSDoc
mysticatea 4d36c8a
Chore: modularize TokenStore
mysticatea 720d702
Chore: fix plural in test descriptions
mysticatea da1db34
Fix: add assertions for options.skip and options.count
mysticatea 91226e2
Chore: it/ic → tokenIndex/commentIndex
mysticatea File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had one one more thought on my second pass through this - do you think it's worth throwing an error with a helpful message when
skip
orcount
are not positive integers? I'm a fan of failing fast and showing a useful error message, since it can help people avoid frustrating debugging.