fix typo in arrow-parens.md #8132
Conversation
|
@wwwillchen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @gcochard, @Jxck and @IanVS to be potential reviewers. |
|
Thanks for the pull request, @wwwillchen! I took a look to make sure it's ready for merging and found some changes are needed:
Can you please update the pull request to address these? (More information can be found in our pull request guide.) |
|
LGTM 👍 |
| @@ -58,7 +58,7 @@ String options are: | |||
|
|
|||
| Object properties for variants of the `"as-needed"` option: | |||
|
|
|||
| * `"requireForBlockBody": true` modifies the as-needed rule in order to require parens if the function body is in an intructions block (surrounded by braces). | |||
| * `"requireForBlockBody": true` modifies the as-needed rule in order to require parens if the function body is in an instructions block (surrounded by braces). | |||
There was a problem hiding this comment.
I'm a bit confused on what this is actually trying to say, to be honest. Is this saying if the arrow body is a block with statements in it? If so, I think I would prefer "statement block" or "block with statements"...
There was a problem hiding this comment.
Lol, guess I was too slow. Thanks @wwwillchen for contributing!
There was a problem hiding this comment.
lol yeah... he was trying to fix the spelling. 😄
eslint-deprecated
bot
added
the
archived due to age
What is the purpose of this pull request? (put an "X" next to item)
[x ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Fixed a typo