Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: fix false negative of no-useless-escape in template literal tags #8238

Merged
merged 1 commit into from
Mar 16, 2017

Conversation

not-an-aardvark
Copy link
Member

@not-an-aardvark not-an-aardvark commented Mar 12, 2017

What is the purpose of this pull request? (put an "X" next to item)

[x] Bug fix

Tell us about your environment

  • ESLint Version: master
  • Node Version: 7.7.2
  • npm Version: 4.1.2

What parser (default, Babel-ESLint, etc.) are you using?

default

Please show your full configuration:

rules:
  no-useless-escape: error
parserOptions:
  ecmaVersion: 2015

What did you do? Please include the actual source code causing the issue.

`\a```

What did you expect to happen?

I expected the \a to be reported as a useless escape.

What actually happened? Please include the actual, raw output from ESLint.

No errors were reported.

What changes did you make? (Give an overview)

This fixes a check in no-useless-escape for tagged template literals. Previously, the rule would exclude any TemplateLiteral whose parent was a TaggedTemplateExpression. This is because backslashes in the "literal" part of a tagged template can be observed by the tag function. However, this doesn't apply to the tag itself, so if a template literal is a tag for another template literal, the rule should check for useless escapes in the tag.

Is there anything you'd like reviewers to focus on?

Nothing in particular

@not-an-aardvark not-an-aardvark added accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly rule Relates to ESLint's core rules labels Mar 12, 2017
@mention-bot
Copy link

@not-an-aardvark, thanks for your PR! By analyzing the history of the files in this pull request, we identified @kaicataldo, @onurtemizkan and @vitorbal to be potential reviewers.

@eslintbot
Copy link

LGTM

@not-an-aardvark not-an-aardvark merged commit 7d1af86 into master Mar 16, 2017
@not-an-aardvark not-an-aardvark deleted the tagged-template-escapes branch March 16, 2017 16:15
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants