Update: fix false negative of no-useless-escape in template literal tags #8238
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[x] Bug fix
Tell us about your environment
What parser (default, Babel-ESLint, etc.) are you using?
default
Please show your full configuration:
What did you do? Please include the actual source code causing the issue.
What did you expect to happen?
I expected the
\a
to be reported as a useless escape.What actually happened? Please include the actual, raw output from ESLint.
No errors were reported.
What changes did you make? (Give an overview)
This fixes a check in
no-useless-escape
for tagged template literals. Previously, the rule would exclude anyTemplateLiteral
whose parent was aTaggedTemplateExpression
. This is because backslashes in the "literal" part of a tagged template can be observed by the tag function. However, this doesn't apply to the tag itself, so if a template literal is a tag for another template literal, the rule should check for useless escapes in the tag.Is there anything you'd like reviewers to focus on?
Nothing in particular