Fix: broken code path of direct nested loops (fixes #8248)

[mysticatea]

What is the purpose of this pull request? (put an "X" next to item)

[X] Bug fix (template)

Fixes #8248.

What changes did you make? (Give an overview)

This PR fixes the broken code path about the direct nest of same kind loops.
The fix is below. Other diffs are for tests.

@@ -512,13 +512,8 @@ function processCodePathToExit(analyzer, node) {
             break;
     }
 
-    /*
-     * Skip updating the current segment to avoid creating useless segments if
-     * the node type is the same as the parent node type.
-     */
-    if (!dontForward && (!node.parent || node.type !== node.parent.type)) {
-
-        // Emits onCodePathSegmentStart events if updated.
+    // Emits onCodePathSegmentStart events if updated.
+    if (!dontForward) {
         forwardCurrentToHead(analyzer, node);
     }
     debug.dumpState(node, state, true);

I had been trying to optimize the code path, but it has been breaking.
I just removed the broken optimizing code.

As a result, the code path about the direct nest of same kind loops is recovered.
For example:

while (a)
    while (b)
        foo()

Before: outer loop's looping path is lacking.

After: OK.

---

Is there anything you'd like reviewers to focus on?

http://www.webgraphviz.com/ is useful to confirm test's code path with DOT diagrams.

[mention-bot]

@mysticatea, thanks for your PR! By analyzing the history of the files in this pull request, we identified @kaicataldo, @platinumazure and @gyandeeps to be potential reviewers.

[eslintbot]

LGTM

[eslintbot]

LGTM

[not-an-aardvark]

LGTM. Thanks!