Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: no-extra-parens invalid autofix in for-of statements #8337

Merged
merged 1 commit into from Mar 27, 2017

Conversation

not-an-aardvark
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[x] Bug fix

Tell us about your environment

  • ESLint Version: master
  • Node Version: 7.7.4
  • npm Version: 4.1.2

What parser (default, Babel-ESLint, etc.) are you using?

default

Please show your full configuration:

parserOptions:
  ecmaVersion: 6
rules:
  no-extra-parens: error

What did you do? Please include the actual source code causing the issue.

for (foo of(bar));

What did you expect to happen?

I expected the code to be fixed to valid syntax:

for (foo of bar);

What actually happened? Please include the actual, raw output from ESLint.

The code was autofixed to invalid syntax:

for (foo ofbar);

What changes did you make? (Give an overview)

This commit fixes a bug in the no-extra-parens autofixer where if the right side of a for-of predicate had extra parens, it would sometimes get combined with the of token.

Is there anything you'd like reviewers to focus on?

Nothing in particular

This commit fixes a bug in the `no-extra-parens` autofixer where if the right side of a `for-of` predicate had extra parens, it would sometimes get combined with the `of` token.
@not-an-aardvark not-an-aardvark added accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly rule Relates to ESLint's core rules labels Mar 26, 2017
@mention-bot
Copy link

@not-an-aardvark, thanks for your PR! By analyzing the history of the files in this pull request, we identified @vitorbal, @kaicataldo and @mysticatea to be potential reviewers.

@eslintbot
Copy link

LGTM

@gyandeeps gyandeeps merged commit 6eda3b5 into master Mar 27, 2017
@not-an-aardvark not-an-aardvark deleted the no-extra-parens-spacing branch March 27, 2017 19:53
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants