Fix: no-extra-parens false positive with objects following arrows #8339
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[x] Bug fix
Tell us about your environment
What parser (default, Babel-ESLint, etc.) are you using?
default
Please show your full configuration:
What did you do? Please include the actual source code causing the issue.
What did you expect to happen?
I expected no error to be reported.
What actually happened? Please include the actual, raw output from ESLint.
An error was reported. The rule suggested fixing the code to
which is invalid syntax.
What changes did you make? (Give an overview)
Previously, the no-extra-parens rule correctly did not report an error when an arrow function returned a parenthesized object expression. However, it would still report an error if an arrow function had a parenthesized object curly as its first token. This commit updates the rule to not report a paren between an arrow token and an opening curly token.
Is there anything you'd like reviewers to focus on?
I'm wondering if there's a better way to check for this case.